Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve imports for incomplete inputs also #1542

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Resolve imports for incomplete inputs also #1542

merged 1 commit into from
Aug 25, 2023

Conversation

jneem
Copy link
Member

@jneem jneem commented Aug 24, 2023

When encountering a import "foo.ncl" statement as part of an incomplete input, load and check the imported file. (This was already done for imports in files that parse completely.)

Fixes #1479

@github-actions github-actions bot temporarily deployed to pull request August 24, 2023 23:19 Inactive
@jneem jneem added this pull request to the merge queue Aug 25, 2023
Merged via the queue into master with commit 26faf51 Aug 25, 2023
4 checks passed
@jneem jneem deleted the resolve-imports branch August 25, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(import "foo.ncl").x doesn't play well with the LSP completion
2 participants